Skip to content

feat(contract): Show Dataset's Siblings Contract Information #11926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthew-coudert-cko wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(contract): Show Dataset's Siblings Contract Information #11926

matthew-coudert-cko wants to merge 3 commits into from

Conversation

@matthew-coudert-cko
Copy link
Contributor

@matthew-coudert-cko matthew-coudert-cko commented Nov 22, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

We show the Snowflake asset by default in DataHub, but our contracts are created in code in DBT. This led to contract information not being visible via the UI.

This resolves that.

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 22, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 22, 2024
jjoyce0510
jjoyce0510 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks quite good - thank you! Once CI passes we should be okay to proceed

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Nov 25, 2024
@jjoyce0510
Copy link
Collaborator

jjoyce0510 commented Nov 26, 2024

Looks like we have some build & test failures - please take a look before merge!

@hsheth2 hsheth2 added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed merge-pending-ci A PR that has passed review and should be merged once CI is green. labels Dec 4, 2024
@shirshanka
Copy link
Contributor

shirshanka commented Dec 14, 2024

@matthew-coudert-cko - you need to run
./gradlew :datahub-web-react:yarnLintFix to fix these issues.

asikowitz
asikowitz reviewed Jul 18, 2025
View reviewed changes
datahub-web-react/src/graphql/contract.graphql
...dataContractDetails
}
siblings {
siblings {
Copy link
Collaborator

@asikowitz asikowitz Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use siblingsSearch now to limit how many siblings get returned, in case there's a ton of siblings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asikowitz asikowitz asikowitz left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

No one assigned

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthew-coudert-cko @jjoyce0510 @shirshanka @asikowitz @hsheth2