Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirrors for building in enterprise environments #11854

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mihai103
Copy link

Allow enterprise developers to build it behind corporate firewalls

Issue faced
At my company we're prohibited to pull from most public registries (Gradle, Maven, Npm, ...) directly and are forced to go via artifactory mirrors.

There are some missing mirrors that are blocking the isolated build process. I propose the current changes, that add the possibility to pass the GOPROXY_URL mirror as a build argument in the dockerfiles and a npm registry mirror for installing yarn, which can be set through gradle opts property npmRegistryBaseUrl.

With these mirrors set the build is working in the corporate environment. When exiting the corporate network and unsetting these mirrors everything works for me like before.

Please let me know if you see something missing or something is not working properly for you.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 14, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant