Enhancements to the user pic list selection within entities #11803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
shirshanka
added
the
datahub-community-champion
jjoyce0510
reviewed
Nov 25, 2024
...hub-web-react/src/app/entity/shared/containers/profile/sidebar/Ownership/EditOwnersModal.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 25, 2024
...hub-web-react/src/app/entity/shared/containers/profile/sidebar/Ownership/EditOwnersModal.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Nov 25, 2024
Collaborator
jjoyce0510
left a comment
jjoyce0510
left a comment
There was a problem hiding this comment.
Overall approach seems okay. A few suggested changes:
- Design: Instead of using dashes to separate each of these items, which makes it a bit long horizontally and difficult to read, I would suggest placing the username, title, and department below if present.
- Variable naming
jjoyce0510
reviewed
Nov 25, 2024
...hub-web-react/src/app/entity/shared/containers/profile/sidebar/Ownership/EditOwnersModal.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Dec 9, 2024
...hub-web-react/src/app/entity/shared/containers/profile/sidebar/Ownership/EditOwnersModal.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
One comment, also build & test is failing |
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
Deepalijain13
force-pushed
the
dj-owner-changes
branch
from
4b615ae to
c1467da
Compare
jjoyce0510
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 662 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: There are a lot of users with identical name so in order to differentiate we have added the username, title and departmentID so that the right owner can be selected by the consumer.
Added username and departmentID and title in the Owners dropdown
Checklist