fix(ingest/redshift): fix serverless redshift temp table lineage #11625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
hsheth2
reviewed
Dec 4, 2024
Contributor
hsheth2
left a comment
hsheth2
left a comment
There was a problem hiding this comment.
mostly seems reasonable, just had one question
| REGEXP_REPLACE(REGEXP_SUBSTR(REGEXP_REPLACE(query_text,'\\\\n','\\n'), '(CREATE(?:[\\n\\s\\t]+(?:temp|temporary))?(?:[\\n\\s\\t]+)table(?:[\\n\\s\\t]+)[^\\n\\s\\t()-]+)', 0, 1, 'ipe'),'[\\n\\s\\t]+',' ',1,'p') AS create_command, | ||
| ROW_NUMBER() OVER ( | ||
| PARTITION BY session_id, query_text | ||
| PARTITION BY session_id, query_text, query_id |
Contributor
There was a problem hiding this comment.
do we need to partition by both?
Suggested change
| PARTITION BY session_id, query_text, query_id | |
| PARTITION BY session_id, query_id |
datahub-cyborg
bot
added
the
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A session can consist of multiple query_id. If multiple SQL commands are used to create several temp tables in a session, only one temp table lineage will be generated. This PR fixes this issue.
Checklist