fix(XServiceProvider): fix ebean framework race condition #11378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
the
devops
Fixes race condition when GMS recieves a request during startup causing required initialization of ebean framework to fail.
david-leifker
force-pushed
the
base-image-update
branch
from
4d45209 to
ec704b9
Compare
david-leifker
changed the title
david-leifker
commented
Sep 15, 2024
| @@ -73,6 +73,17 @@ public void onApplicationEvent(@Nonnull ContextRefreshedEvent event) { | |||
| event); | |||
| String schemaRegistryType = provider.getKafka().getSchemaRegistry().getType(); | |||
| if (ROOT_WEB_APPLICATION_CONTEXT_ID.equals(event.getApplicationContext().getId())) { | |||
|
|
|||
| // Handle race condition, if ebean code is executed while waiting/bootstrapping (i.e. | |||
There was a problem hiding this comment.
This is the required fix.
darnaut
approved these changes
Sep 15, 2024
RyanHolstien
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating to the latest executor code in actions, a GMS startup race condition is triggered by incomplete
initialization of the ebean framework during integration/smoke-tests.
This PR fixes the race condition by loading the class prior to starting the wait/bootstrap process during GMS startup. This allows AuthenticationFilter to handle requests which require interaction with SQL via the ebean library as the application is loading.
Notes:
In production environments running kubernetes the pod would not be expected to receive traffic before the health check is healthy and would avoid this condition.
Checklist