Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): forUpdate needed for versioning #11328

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(version): forUpdate needed for versioning #11328

merged 2 commits into from
Sep 10, 2024
+35 −13

Conversation

david-leifker
Copy link
Collaborator

  • forUpdate is required for a read lock whenever calculating a version

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker
fix(version): forUpdate needed for versioning
4fa559d 
* forUpdate is required for a read lock whenever calculating a version
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 8, 2024
@david-leifker david-leifker merged commit c6eea1e into datahub-project:master Sep 10, 2024
41 checks passed
@Masterchen09
Copy link
Contributor

Hi @david-leifker,

I just noticed that when you are using a PostgreSQL database the changes in EbeanAspectDao.java regarding the forUpdate are causing a NullPointerException when starting the GMS now:

2024-09-10 21:14:32,143 [pool-2-thread-1] ERROR c.l.metadata.boot.BootstrapManager:40 - Caught exception while executing bootstrap step IngestDataPlatformsStep. Exiting...
2024-09-10 23:14:32 java.lang.NullPointerException: Cannot invoke "io.ebean.Query$LockType.ordinal()" because "lockType" is null
2024-09-10 23:14:32     at io.ebean.config.dbplatform.postgres.PostgresPlatform.lock(PostgresPlatform.java:140)
2024-09-10 23:14:32     at io.ebean.config.dbplatform.postgres.PostgresPlatform.withForUpdate(PostgresPlatform.java:135)
2024-09-10 23:14:32     at io.ebean.config.dbplatform.DatabasePlatform.completeSql(DatabasePlatform.java:717)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryBuilder$BuildReq.buildSql(CQueryBuilder.java:729)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryBuilder$BuildReq.access$100(CQueryBuilder.java:530)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryBuilder.buildSql(CQueryBuilder.java:519)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryBuilder.buildFetchAttributeQuery(CQueryBuilder.java:198)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryBuilder.buildFetchIdsQuery(CQueryBuilder.java:215)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.CQueryEngine.findIds(CQueryEngine.java:145)
2024-09-10 23:14:32     at io.ebeaninternal.server.query.DefaultOrmQueryEngine.findIds(DefaultOrmQueryEngine.java:96)
2024-09-10 23:14:32     at io.ebeaninternal.server.core.OrmQueryRequest.findIds(OrmQueryRequest.java:355)
2024-09-10 23:14:32     at io.ebeaninternal.server.core.DefaultServer.findIdsWithCopy(DefaultServer.java:1276)
2024-09-10 23:14:32     at io.ebeaninternal.server.core.DefaultServer.findIds(DefaultServer.java:1259)
2024-09-10 23:14:32     at io.ebeaninternal.server.querydefn.DefaultOrmQuery.findIds(DefaultOrmQuery.java:1418)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.ebean.EbeanAspectDao.getNextVersions(EbeanAspectDao.java:828)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.EntityUtils.calculateNextVersions(EntityUtils.java:336)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.EntityServiceImpl.lambda$ingestAspectsToLocalDB$40(EntityServiceImpl.java:853)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.ebean.EbeanAspectDao.runInTransactionWithRetryUnlocked(EbeanAspectDao.java:742)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.ebean.EbeanAspectDao.runInTransactionWithRetry(EbeanAspectDao.java:717)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.EntityServiceImpl.ingestAspectsToLocalDB(EntityServiceImpl.java:837)
2024-09-10 23:14:32     at com.linkedin.metadata.entity.EntityServiceImpl.ingestAspects(EntityServiceImpl.java:773)
2024-09-10 23:14:32     at com.linkedin.metadata.boot.steps.IngestDataPlatformsStep.execute(IngestDataPlatformsStep.java:108)
2024-09-10 23:14:32     at com.linkedin.metadata.boot.BootstrapManager.start(BootstrapManager.java:38)
2024-09-10 23:14:32     at com.linkedin.metadata.boot.OnBootApplicationListener.lambda$isSchemaRegistryAPIServletReady$0(OnBootApplicationListener.java:109)
2024-09-10 23:14:32     at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
2024-09-10 23:14:32     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2024-09-10 23:14:32     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
2024-09-10 23:14:32     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
2024-09-10 23:14:32     at java.base/java.lang.Thread.run(Thread.java:840)

I have reproduced this on a local build on https://github.com/datahub-project/datahub/tree/837d00d391a9f3c6d79cbed9969fe4003e36f580.

I am not sure whether this is caused by a bug in the Ebean ORM library or if there must be changed something else regarding the forUpdate in EbeanAspectDao...what I was able to find out is that the PostgresPlatform seems to be using the lockType (which is null) in withForUpdate resp. lock, while the BaseMySqlPlatform (parent of MySqlPlatform) is ignoring the parameter (therefore it does not matter that the lockType is null):

https://github.com/ebean-orm/ebean/blob/12.16.3/ebean-api/src/main/java/io/ebean/config/dbplatform/postgres/PostgresPlatform.java#L128

https://github.com/ebean-orm/ebean/blob/12.16.3/ebean-api/src/main/java/io/ebean/config/dbplatform/mysql/BaseMySqlPlatform.java#L64

Maybe you could check this? 😊

@Masterchen09
Copy link
Contributor

Hi @david-leifker,

after digging a bit deeper I found this comment in the copy method in DefaultOrmQuery of the Ebean ORM library: https://github.com/ebean-orm/ebean/blob/edbd13c0754ed23fc8e4958a1f43dbc76c09026a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java#L746

The copy method of DefaultOrmQuery is called when findIds resp. findIdsWithCopy is called in DefaultServer - see also here:

at io.ebeaninternal.server.core.DefaultServer.findIdsWithCopy(DefaultServer.java:1276)
at io.ebeaninternal.server.core.DefaultServer.findIds(DefaultServer.java:1259)

Although I do not fully understand the backgrounds, the mentioned issue sounds like forUpdate is incorrectly used in context of getNextVersions resp. in relation to findIds? Is it possible that forUpdate is also incorrectly used in getLatestAspects and in relation to findList (although it seems in relation to findList no copy of the query is created...)?

Maybe this helps you a bit?

@david-leifker
Copy link
Collaborator Author

@Masterchen09 - I will find a resolution here and get a PR up to fix it. This has proven effective in solving a production issue with mysql for us. Hopefully we can find a solution that will for both.

@david-leifker
Copy link
Collaborator Author

The exception seems to be resolved by updating the ebean library see -> #11379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @Masterchen09 @pedro93