Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mode/ingest): Add support for missing Mode datasets in lineage #11290

Merged
merged 3 commits into from
Sep 10, 2024
Merged

feat(mode/ingest): Add support for missing Mode datasets in lineage #11290

merged 3 commits into from
Sep 10, 2024

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 3, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-692/mode-dataset-lineage branch from 3f163de to 5286728 Compare September 5, 2024 15:28
@sagar-salvi-apptware sagar-salvi-apptware changed the title feat(mode/ingest): Correct lineage handling for imported datasets by ensuring proper URN usage and establishing correct downstream relationships feat(mode/ingest): Add support for missing Mode datasets in lineage Sep 5, 2024
hsheth2
hsheth2 reviewed Sep 5, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/mode.py
# This is hacky but on bigquery we want to change the database if its default
# For lineage we need project_id.db.table
if platform == "bigquery" and database == "default":
database = data_source.get("host", "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is normally in the "host" key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host in this case is BQ Project ID.

"database": "default",
 "host": "harshal-playground-306419",

metadata-ingestion/src/datahub/ingestion/source/mode.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/mode.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/mode.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/mode.py Show resolved Hide resolved
metadata-ingestion/tests/integration/mode/mode_mces_golden.json Outdated Show resolved Hide resolved
@sagar-salvi-apptware
feat(mode/ingest): Correct lineage handling for imported datasets by …
5577696 
…ensuring proper URN usage and establishing correct downstream relationships
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-692/mode-dataset-lineage branch from 5286728 to 5577696 Compare September 6, 2024 04:35
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-692/mode-dataset-lineage branch from c6fa4e9 to 574ad7d Compare September 9, 2024 09:57
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review September 9, 2024 10:02
@hsheth2 hsheth2 merged commit 852a23b into datahub-project:master Sep 10, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar-salvi-apptware @hsheth2