fix(gms): filter out runs of a dataJob without any run-events #11223

ksrinath · 2024-08-22T13:52:23Z

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-08-22T13:52:33Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

david-leifker

None of this code is required to add a hasXXX field and this implementation is not correctly handling the ES index mapping.

This feature should be implemented by adding a @searchable annotation to the entity on the timeseries field in the pdl model. This is done with an annotation called hasValuesFieldName and will both update the ES mapping and populate the boolean without any additional code beyond the addition to the annotation.

david-leifker · 2024-08-28T14:49:17Z

metadata-models/src/main/pegasus/com/linkedin/dataprocess/DataProcessInstanceRunEvent.pdl

@@ -15,6 +15,10 @@ import com.linkedin.common.Urn
 record DataProcessInstanceRunEvent includes TimeseriesAspectBase, ExternalReference {

  @TimeseriesField = {}
+  @Searchable = {
+    "fieldType": "TEXT",


This should either be removed or set to KEYWORD. The reason is that the value is of type enum which would default to KEYWORD.

david-leifker

The upgrade job looks really good!

Add a delayMs to the primary while loop. This should be set to a default of 1000 millis. The reason is that we want to throttle a little as the aggregation query can put load on the ES cluster and allows us to increase the delay if it triggers alerts on the cluster.
The aggregation query should specify a time window start/stop on the timeseries aspect index. We've seen negative performance impacts from querying the entire timeseries indices (A customer with large timeseries would be Robinhood for example). I would expect the query to iterate on buckets of time. For example, a 1 day window. - Bonus points if the window is fully configurable, but a good conservative default would be to aggregate timeseries data 1 day at a time and maybe assume that it processes the last 90d.

david-leifker

The aggregation query will only return batchSize (top N) urns from the timeseries index. How does this code not just update the batchSize most frequent entities?

ksrinath · 2024-09-04T14:39:49Z

The aggregation query will only return batchSize (top N) urns from the timeseries index. How does this code not just update the batchSize most frequent entities?

The afterKey is updated in the outer-indefinite-while loop, so that all the distinct-urns should get read by the time we break out of the while-loop. Am I missing something here?

ksrinath · 2024-09-05T12:48:38Z

Add a delayMs to the primary while loop. This should be set to a default of 1000 millis. The reason is that we want to throttle a little as the aggregation query can put load on the ES cluster and allows us to increase the delay if it triggers alerts on the cluster.

Updated code for this; can you please review.

david-leifker · 2024-09-06T16:23:15Z

The aggregation query will only return batchSize (top N) urns from the timeseries index. How does this code not just update the batchSize most frequent entities?

The afterKey is updated in the outer-indefinite-while loop, so that all the distinct-urns should get read by the time we break out of the while-loop. Am I missing something here?

RIght, it is using the Composite aggregator here. It should work.

metadata-service/configuration/src/main/resources/application.yaml

david-leifker · 2024-09-06T16:25:58Z

@ksrinath - I am not seeing delayMs - missing changes?

ksrinath · 2024-09-10T12:51:54Z

The aggregation query should specify a time window start/stop on the timeseries aspect index. We've seen negative performance impacts from querying the entire timeseries indices (A customer with large timeseries would be Robinhood for example). I would expect the query to iterate on buckets of time. For example, a 1 day window. - Bonus points if the window is fully configurable, but a good conservative default would be to aggregate timeseries data 1 day at a time and maybe assume that it processes the last 90d.

Can you please review the updated code.

david-leifker

LGTM! Great job!

fix(gms): filter out runs of a dataJob without any run-events

1d844bb

github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Aug 22, 2024

vercel bot deployed to Preview August 22, 2024 14:09 View deployment

Merge branch 'master' into fix/filter-runs-without-state

043f697

vercel bot deployed to Preview August 22, 2024 14:48 View deployment

ksrinath closed this Aug 23, 2024

perf improvement, comments on pagination behavior

827fee4

ksrinath reopened this Aug 23, 2024

vercel bot deployed to Preview August 23, 2024 11:42 View deployment

ksrinath closed this Aug 28, 2024

updated implementation, filtering on a new hasRunEvents field

93b261f

ksrinath reopened this Aug 28, 2024

ksrinath added 2 commits August 28, 2024 17:26

spotless

bb10b02

spotless

cfcd688

david-leifker requested changes Aug 28, 2024

View reviewed changes

vercel bot deployed to Preview August 28, 2024 12:33 View deployment

simply add searchable annotation in pdl instead of creating a new hook

42b54cd

vercel bot deployed to Preview August 28, 2024 14:42 View deployment

david-leifker reviewed Aug 28, 2024

View reviewed changes

misc fix

4fb5e8c

david-leifker approved these changes Aug 28, 2024

View reviewed changes

vercel bot deployed to Preview August 28, 2024 15:53 View deployment

WIP backfilling dataProcessInstances

f158490

vercel bot deployed to Preview August 30, 2024 07:51 View deployment

reprocess-flag, config parameters

df1e6e8

vercel bot deployed to Preview September 2, 2024 06:52 View deployment

Merge branch 'master' into fix/filter-runs-without-state

fa480cc

vercel bot deployed to Preview September 2, 2024 07:16 View deployment

misc fix

4c41415

vercel bot deployed to Preview September 2, 2024 12:09 View deployment

ksrinath requested a review from david-leifker September 2, 2024 14:06

david-leifker requested changes Sep 3, 2024

View reviewed changes

Merge branch 'master' into fix/filter-runs-without-state

b61c65a

vercel bot deployed to Preview September 5, 2024 08:35 View deployment

fix compile errors due to upstream changes; misc.

140082a

vercel bot deployed to Preview September 5, 2024 09:07 View deployment

add batchDelayMs to throttle aggregation query

dd798f3

david-leifker self-assigned this Sep 6, 2024

david-leifker reviewed Sep 6, 2024

View reviewed changes

metadata-service/configuration/src/main/resources/application.yaml Show resolved Hide resolved

vercel bot deployed to Preview September 6, 2024 17:36 View deployment

Merge branch 'master' into fix/filter-runs-without-state

1795d50

vercel bot deployed to Preview September 6, 2024 18:35 View deployment

Merge branch 'master' into fix/filter-runs-without-state

1b2f733

vercel bot deployed to Preview September 10, 2024 07:04 View deployment

time-window filtering and capped history

72cc63a

vercel bot deployed to Preview September 10, 2024 11:22 View deployment

david-leifker approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'master' into fix/filter-runs-without-state

5098697

vercel bot deployed to Preview September 11, 2024 04:14 View deployment

ksrinath marked this pull request as ready for review September 11, 2024 04:36

david-leifker merged commit fd6d4c8 into datahub-project:master Sep 11, 2024
73 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gms): filter out runs of a dataJob without any run-events #11223

fix(gms): filter out runs of a dataJob without any run-events #11223

ksrinath commented Aug 22, 2024

coderabbitai bot commented Aug 22, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

david-leifker left a comment

david-leifker Aug 28, 2024

david-leifker left a comment •

edited

Loading

david-leifker left a comment

ksrinath commented Sep 4, 2024 •

edited

Loading

ksrinath commented Sep 5, 2024

david-leifker commented Sep 6, 2024

david-leifker commented Sep 6, 2024

ksrinath commented Sep 10, 2024

david-leifker left a comment

fix(gms): filter out runs of a dataJob without any run-events #11223

fix(gms): filter out runs of a dataJob without any run-events #11223

Conversation

ksrinath commented Aug 22, 2024

Checklist

coderabbitai bot commented Aug 22, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

david-leifker left a comment

Choose a reason for hiding this comment

david-leifker Aug 28, 2024

Choose a reason for hiding this comment

david-leifker left a comment • edited Loading

Choose a reason for hiding this comment

david-leifker left a comment

Choose a reason for hiding this comment

ksrinath commented Sep 4, 2024 • edited Loading

ksrinath commented Sep 5, 2024

david-leifker commented Sep 6, 2024

david-leifker commented Sep 6, 2024

ksrinath commented Sep 10, 2024

david-leifker left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Aug 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

david-leifker left a comment •

edited

Loading

ksrinath commented Sep 4, 2024 •

edited

Loading