-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingestion/tableau): Tableau field type parsing #11202
fix(ingestion/tableau): Tableau field type parsing #11202
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# The check here makes sure that even if 'dataType' key exists in the 'field' dictionary but has value None, | ||
# it will be set as "UNKNOWN" (nativeDataType field can not be None in the SchemaField). | ||
# Hence, field.get("dataType", "UNKNOWN") is not enough | ||
nativeDataType = field.get("dataType") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeDataType = field.get("dataType") | |
nativeDataType = field.get("dataType") or "UNKNOWN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have considered that solution but or
will also trigger if field.get("dataType")
returns some actual value such as False
or, worse, if it is an empty string
. If you feel this cases should also be handled as "UNKNOWN" (which I believe so as well, made this build just to test a theory) I will gladly adjust to your change. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either is probably fine - I expect field.get("dataType")
is only going to be string or None
I just like the or
thing because it's more concise, but it's not a particularly important suggestion. we should be fine merging this as long as you've validated that it does fix the bug
Checklist