Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): Add page number to SearchResultClickEvent analytics event #11151

Merged
merged 6 commits into from
Aug 20, 2024
Merged

feat(analytics): Add page number to SearchResultClickEvent analytics event #11151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
891be3c
feat(analytics): Add pageNumber to SearchResultClickEvent
filipe-caetano-ovo Aug 12, 2024
3e2052a
docs(developers): Fix type in developers.md
filipe-caetano-ovo Aug 12, 2024
3739fa6
Fix linting issues
filipe-caetano-ovo Aug 14, 2024
9757946
Merge branch 'datahub-project:master' into add-page-number-to-search-…
filipe-caetano-ovo Aug 14, 2024
a52deea
Merge branch 'master' into add-page-number-to-search-analytics
filipe-caetano-ovo Aug 15, 2024
30f7ae9
Merge branch 'master' into add-page-number-to-search-analytics
filipe-caetano-ovo Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datahub-web-react/src/app/analytics/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ export interface SearchResultClickEvent extends BaseEvent {
entityTypeFilter?: EntityType;
index: number;
total: number;
pageNumber: number;
}

export interface SearchFiltersClearAllEvent extends BaseEvent {
Expand Down
3 changes: 3 additions & 0 deletions datahub-web-react/src/app/search/SearchResultList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ type Props = {
selectedEntities: EntityAndType[];
setSelectedEntities: (entities: EntityAndType[]) => any;
suggestions: SearchSuggestion[];
pageNumber: number;
};

export const SearchResultList = ({
Expand All @@ -73,6 +74,7 @@ export const SearchResultList = ({
selectedEntities,
setSelectedEntities,
suggestions,
pageNumber,
}: Props) => {
const entityRegistry = useEntityRegistry();
const selectedEntityUrns = selectedEntities.map((entity) => entity.urn);
Expand All @@ -86,6 +88,7 @@ export const SearchResultList = ({
entityType: result.entity.type,
index,
total: totalResultCount,
pageNumber,
});
};

Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/app/search/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ export const SearchResults = ({
selectedEntities={selectedEntities}
setSelectedEntities={setSelectedEntities}
suggestions={suggestions}
pageNumber={page}
/>
{totalResults > 0 && (
<PaginationControlContainer id="search-pagination">
Expand Down
2 changes: 1 addition & 1 deletion docs/developers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Use [gradle wrapper](https://docs.gradle.org/current/userguide/gradle_wrapper.ht
./gradlew build
```

Note that the above will also run run tests and a number of validations which makes the process considerably slower.
Note that the above will also run tests and a number of validations which makes the process considerably slower.

We suggest partially compiling DataHub according to your needs:

Expand Down
Loading