-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs: add signup form in cloud #11129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe updates introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Hero Component
participant HubSpot Script
User->>Hero Component: Load page
Hero Component->>HubSpot Script: Load form script
HubSpot Script-->>Hero Component: Form loaded
Hero Component->>User: Display form with user-friendly prompts
User->>Hero Component: Fill and submit form
Hero Component->>User: Display success/error message
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- docs-website/src/pages/cloud/Hero/hubspotFormStyles.css (1 hunks)
- docs-website/src/pages/cloud/Hero/index.js (1 hunks)
- docs-website/src/pages/cloud/Hero/styles.module.scss (1 hunks)
- docs-website/src/pages/cloud/index.js (2 hunks)
- docs-website/src/pages/cloud/styles.module.scss (1 hunks)
Files skipped from review due to trivial changes (3)
- docs-website/src/pages/cloud/Hero/hubspotFormStyles.css
- docs-website/src/pages/cloud/Hero/styles.module.scss
- docs-website/src/pages/cloud/styles.module.scss
Additional comments not posted (6)
docs-website/src/pages/cloud/index.js (3)
11-11: Import ofHerocomponent looks good.The
Herocomponent is correctly imported, aligning with the changes made in the file.
28-28: Usage ofHerocomponent is appropriate.The
Herocomponent is correctly integrated into the layout, enhancing modularity.
28-28: Removal ofScrollingCustomerscomponent is consistent with the simplification strategy.Ensure that this change does not impact any other functionality or user experience.
docs-website/src/pages/cloud/Hero/index.js (3)
1-6: Imports inHerocomponent are correct.The necessary modules and styles are correctly imported for the component's functionality.
66-104: Rendering logic inHerocomponent is correct.The component renders the header, form, and links as intended, aligning with the design goals.
9-64: Verify script loading and cleanup inuseEffect.The
useEffecthook correctly loads the HubSpot script and manages form placeholders. Ensure that the script source is trusted and the cleanup process is robust.
Co-authored-by: jayacryl <[email protected]>
Checklist
Summary by CodeRabbit
New Features
Herocomponent to enhance the promotion of DataHub Cloud services with a visually integrated HubSpot form.Bug Fixes
Refactor
Herocomponent, streamlining the layout.Style