Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/qlik): improve logging for debug #10659

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(ingest/qlik): improve logging for debug #10659

merged 1 commit into from
Jun 7, 2024

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 7, 2024
treff7es
treff7es reviewed Jun 7, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/qlik_sense/data_classes.py
@@ -164,8 +164,8 @@ class Chart(BaseModel):
@root_validator(pre=True)
def update_values(cls, values: Dict) -> Dict:
values[Constant.QID] = values[Constant.QINFO][Constant.QID]
values["qDimension"] = values["qHyperCube"]["qDimensionInfo"]
values["qMeasure"] = values["qHyperCube"]["qMeasureInfo"]
values["qDimension"] = values[Constant.HYPERCUBE]["qDimensionInfo"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Constans instead of raw strings like what you did with HYPERCUBE?
I would prefer to be consistent in the code.

@anshbansal anshbansal merged commit 6fdf2f7 into master Jun 7, 2024
58 checks passed
@anshbansal anshbansal deleted the ab-improve-logging branch June 7, 2024 12:20
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@anshbansal @sleeperdeep
fix(ingest/qlik): improve logging for debug (datahub-project#10659)
dc2f06e
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@anshbansal @yoonhyejin
fix(ingest/qlik): improve logging for debug (#10659)
e9ec12d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @treff7es @pedro93