Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: merge cli guide #10464

Merged
merged 15 commits into from
Jun 25, 2024
Merged

docs: merge cli guide #10464

merged 15 commits into from
Jun 25, 2024

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels May 9, 2024
@yoonhyejin yoonhyejin requested a review from hsheth2 May 9, 2024 05:21
hsheth2
hsheth2 reviewed May 13, 2024
View reviewed changes
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin requested a review from hsheth2 May 20, 2024 05:24
hsheth2
hsheth2 reviewed May 20, 2024
View reviewed changes
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin requested a review from hsheth2 May 23, 2024 04:49
hsheth2
hsheth2 approved these changes Jun 15, 2024
View reviewed changes
metadata-ingestion/cli-ingestion.md Outdated Show resolved Hide resolved
@hsheth2
Copy link
Collaborator

hsheth2 commented Jun 15, 2024

@yoonhyejin there's a merge conflict here, but this is good to merge other than that

@yoonhyejin yoonhyejin enabled auto-merge (squash) June 25, 2024 00:24
@yoonhyejin yoonhyejin merged commit 49d1233 into master Jun 25, 2024
47 of 50 checks passed
@yoonhyejin yoonhyejin deleted the docs/merge-cli-guide branch June 25, 2024 00:28
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @hsheth2 @sleeperdeep
docs: merge cli guide (datahub-project#10464)
2152d30 
Co-authored-by: Harshal Sheth <[email protected]>
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @hsheth2 @sleeperdeep
docs: merge cli guide (datahub-project#10464)
2c8d513 
Co-authored-by: Harshal Sheth <[email protected]>
yoonhyejin added a commit that referenced this pull request Jul 16, 2024
@yoonhyejin @hsheth2
docs: merge cli guide (#10464)
1ccd9db 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2