Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(entity-registry): add ability to search for float and double #10324

Conversation

Rosmirose
Copy link
Contributor

@Rosmirose Rosmirose commented Apr 18, 2024

Checklist

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Apr 18, 2024
@Rosmirose Rosmirose marked this pull request as ready for review April 22, 2024 08:09
@RyanHolstien RyanHolstien changed the title <feat>[entity-registry: add ability to search for float and double feat:(entity-registry): add ability to search for float and double Apr 22, 2024
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, shouldn't force any mapping changes since the only annotations with float/double marked are in tests. Will merge once CI finishes, don't worry about continuing to merge master in, it makes it where I have to approve the workflow.

@RyanHolstien RyanHolstien merged commit 437b7a1 into datahub-project:master Apr 24, 2024
41 checks passed
@Rosmirose Rosmirose deleted the Support-ES-Indexing-as-Float-or-Double branch April 26, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants