-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(entity-registry): add ability to search for float and double #10324
Merged
RyanHolstien
merged 7 commits into
datahub-project:master
from
Rosmirose:Support-ES-Indexing-as-Float-or-Double
Apr 24, 2024
Merged
feat:(entity-registry): add ability to search for float and double #10324
RyanHolstien
merged 7 commits into
datahub-project:master
from
Rosmirose:Support-ES-Indexing-as-Float-or-Double
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
community-contribution
PR or Issue raised by member(s) of DataHub Community
label
Apr 18, 2024
RyanHolstien
changed the title
<feat>[entity-registry: add ability to search for float and double
feat:(entity-registry): add ability to search for float and double
Apr 22, 2024
RyanHolstien
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, shouldn't force any mapping changes since the only annotations with float/double marked are in tests. Will merge once CI finishes, don't worry about continuing to merge master in, it makes it where I have to approve the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
https://datahubspace.slack.com/archives/CV2KB471C/p1640844759041400
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub