fix(spring): refactor spring configuration #10290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
| stopOnDeserializationError: ${KAFKA_CONSUMER_STOP_ON_DESERIALIZATION_ERROR:true} # Stops kafka listener container on deserialization error, allows user to fix problems before moving past problematic offset. If false will log and move forward past the offset | ||
| healthCheckEnabled: ${KAFKA_CONSUMER_HEALTH_CHECK_ENABLED:true} # Sets the health indicator to down when a message listener container has stopped due to a deserialization failure, will force consumer apps to restart through k8s and docker-compose health mechanisms | ||
| schemaRegistry: | ||
| # type: ${SCHEMA_REGISTRY_TYPE:INTERNAL} # INTERNAL or KAFKA or AWS_GLUE |
Collaborator
There was a problem hiding this comment.
Commented lines can be removed
| import org.springframework.web.context.support.HttpRequestHandlerServlet; | ||
| import org.springframework.web.servlet.DispatcherServlet; | ||
|
|
||
| /** This class is before Spring Context is loaded, previously web.xml based */ |
david-leifker
force-pushed
the
spring-cleaning
branch
from
7051917 to
0d09e84
Compare
david-leifker
force-pushed
the
spring-cleaning
branch
from
0d09e84 to
b199973
Compare
david-leifker
force-pushed
the
spring-cleaning
branch
from
b199973 to
3f4cb59
Compare
* Separated schema registry from common dispatcher * Remove unneeded dependencies on spring boot * Remove unneeded spring actuators from library modules * ObjectMapper bean created * Optimized GMS component scan (avoid scanning all factories) * Remove unneeded references to application.yaml * .yml -> .yaml (handle deprecated extension) * Remove imports on schema registry factories * web.xml (xml configs in general) removed
david-leifker
force-pushed
the
spring-cleaning
branch
from
85ea1a3 to
a391f99
Compare
5 tasks
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist