feat(dbt): show source and compiled code in the UI #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
5 tasks
hsheth2
force-pushed
the
show-dbt-compiled-code
branch
from
a876291 to
bd3489f
Compare
asikowitz
approved these changes
Mar 12, 2024
| const materialized = (baseEntity?.dataset?.viewProperties?.materialized && true) || false; | ||
| const language = baseEntity?.dataset?.viewProperties?.language || 'UNKNOWN'; | ||
|
|
||
| const isDbt = baseEntity?.dataset?.platform?.name?.toLowerCase() === 'dbt'; |
There was a problem hiding this comment.
Can we use a constant here? At the least, DBT in src/app/ingest/source/builder exists
| const materialized = (baseEntity?.dataset?.viewProperties?.materialized && true) || false; | ||
| const language = baseEntity?.dataset?.viewProperties?.language || 'UNKNOWN'; | ||
|
|
||
| const isDbt = baseEntity?.dataset?.platform?.name?.toLowerCase() === 'dbt'; | ||
| const canShowFormatted = formattedLogic && true; |
There was a problem hiding this comment.
Missing conditional here? Otherwise can remove && true
There was a problem hiding this comment.
replaced it with !!formattedLogic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on top of #10026Checklist