Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add DataHubGraph.emit_all method #10002

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat(ingest): add DataHubGraph.emit_all method #10002

merged 4 commits into from
Mar 11, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 7, 2024

  • Makes the DataHubGraph init method not call test_connection.
  • Refactors some of the workunit id generation logic.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(ingest): add DataHubGraph.emit_all method
9d73744 
- Makes the DataHubGraph init method not call test_connection.
- Refactors some of the workunit id generation logic.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 7, 2024
asikowitz
asikowitz approved these changes Mar 11, 2024
View reviewed changes
metadata-ingestion/src/datahub/configuration/source_common.py
@@ -38,7 +38,8 @@ class EnvConfigMixin(ConfigModel):

_env_deprecation = pydantic_field_deprecated(
"env",
message="env is deprecated and will be removed in a future release. Please use platform_instance instead.",
message="We recommend using platform_instance instead of env. "
"While specifying env does still work, we intend to deprecate it in the future.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 11, 2024
@hsheth2 hsheth2 merged commit 5937472 into master Mar 11, 2024
53 checks passed
@hsheth2 hsheth2 deleted the client-emit-all branch March 11, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz