refactor(docker-dev): set up elasticsearch using local mapping on doc…

…ker-compose.dev (#2137) Co-authored-by: Dexter Lee <[email protected]>
datahub-project · Feb 25, 2021 · e7c3fd8 · e7c3fd8
1 parent d2745ee
commit e7c3fd8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/docker/docker-compose.dev.yml b/docker/docker-compose.dev.yml
@@ -11,6 +11,18 @@
 # TODO mount + debug docker file for frontend
 version: '3.8'
 services:
+  # Pre-creates the search indices using local mapping/settings.json
+  elasticsearch-setup:
+    image: elasticsearch-setup:debug
+    build:
+      context: elasticsearch-setup
+      dockerfile: Dockerfile
+      args:
+        APP_ENV: dev
+    volumes:
+      - ./elasticsearch-setup/create-indices.sh:/create-indices.sh
+      - ../gms/impl/src/main/resources/index/:/index
+
   datahub-gms:
     image: linkedin/datahub-gms:debug
     build:

diff --git a/docker/elasticsearch-setup/Dockerfile b/docker/elasticsearch-setup/Dockerfile
@@ -1,10 +1,21 @@
 # This "container" is a workaround to pre-create search indices
-FROM jwilder/dockerize:0.6.1
+
+# Defining environment
+ARG APP_ENV=prod
+
+FROM jwilder/dockerize:0.6.1 AS base
 
 RUN apk add --no-cache curl jq
 
+FROM base AS prod-install
+
 COPY docker/elasticsearch-setup/create-indices.sh /
 RUN chmod 755 create-indices.sh
-COPY gms/impl/src/main/resources/index /
+COPY gms/impl/src/main/resources/index /index
+
+FROM base AS dev-install
+# Dummy stage for development. Use local files for setup
+# See this excellent thread https://github.com/docker/cli/issues/1134
 
+FROM ${APP_ENV}-install AS final
 CMD dockerize -wait http://$ELASTICSEARCH_HOST:$ELASTICSEARCH_PORT -timeout 120s /create-indices.sh
diff --git a/docker/elasticsearch-setup/create-indices.sh b/docker/elasticsearch-setup/create-indices.sh
@@ -4,8 +4,8 @@ set -e
 
 function create_index {
   jq -n \
-    --slurpfile settings $2 \
-    --slurpfile mappings $3 \
+    --slurpfile settings index/$2 \
+    --slurpfile mappings index/$3 \
     '.settings=$settings[0] | .mappings.doc=$mappings[0]' > /tmp/data
 
   curl -XPUT $ELASTICSEARCH_HOST:$ELASTICSEARCH_PORT/$1 --data @/tmp/data