feat(ui): Add Test Connection Support for BigQuery ingestion source (#…

…6543)
datahub-project · Nov 28, 2022 · 6eb63c2 · 6eb63c2
1 parent 4d76b41
commit 6eb63c2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/...web-react/src/app/ingest/source/builder/RecipeForm/TestConnection/TestConnectionModal.tsx b/...web-react/src/app/ingest/source/builder/RecipeForm/TestConnection/TestConnectionModal.tsx
@@ -20,6 +20,7 @@ const LoadingSubheader = styled.div`
     display: flex;
     justify-content: center;
     font-size: 12px;
+    color: ${ANTD_GRAY[7]};
 `;
 
 const LoadingHeader = styled(Typography.Title)`
@@ -53,12 +54,11 @@ const ModalHeader = styled.div`
     display: flex;
     padding: 10px 10px 0 10px;
     padding: 5px;
-    font-size: 20px;
+    font-size: 18px;
 `;
 
 const SourceIcon = styled.img`
     height: 22px;
-    width: 22px;
     margin-right: 10px;
 `;
 
@@ -115,7 +115,7 @@ function TestConnectionModal({
             {isLoading && (
                 <ResultsWrapper>
                     <LoadingHeader level={4}>Testing your connection...</LoadingHeader>
-                    <LoadingSubheader>This could take a few minutes</LoadingSubheader>
+                    <LoadingSubheader>This could take a few minutes.</LoadingSubheader>
                     <LoadingWrapper>
                         <LoadingSvg height={100} width={100} />
                     </LoadingWrapper>

diff --git a/datahub-web-react/src/app/ingest/source/builder/RecipeForm/constants.ts b/datahub-web-react/src/app/ingest/source/builder/RecipeForm/constants.ts
@@ -256,4 +256,4 @@ export const RECIPE_FIELDS: RecipeFields = {
 
 export const CONNECTORS_WITH_FORM = new Set(Object.keys(RECIPE_FIELDS));
 
-export const CONNECTORS_WITH_TEST_CONNECTION = new Set([SNOWFLAKE, LOOKER, BIGQUERY_BETA]);
+export const CONNECTORS_WITH_TEST_CONNECTION = new Set([SNOWFLAKE, LOOKER, BIGQUERY_BETA, BIGQUERY]);
diff --git a/datahub-web-react/src/app/ingest/source/builder/sources.json b/datahub-web-react/src/app/ingest/source/builder/sources.json
@@ -177,8 +177,8 @@
     {
         "urn": "urn:li:dataPlatform:custom",
         "name": "custom",
-        "displayName": "Custom",
+        "displayName": "Other",
         "docsUrl": "https://datahubproject.io/docs/metadata-ingestion/",
         "recipe": "source:\n  type: <source-type>\n  config:\n    # Source-type specifics config\n    <source-configs>"
     }
-]
+]
diff --git a/datahub-web-react/src/app/ingest/source/conf/sources.tsx b/datahub-web-react/src/app/ingest/source/conf/sources.tsx
@@ -49,7 +49,7 @@ export const SOURCE_TEMPLATE_CONFIGS: Array<SourceConfig> = [
     {
         type: 'custom',
         placeholderRecipe: DEFAULT_PLACEHOLDER_RECIPE,
-        displayName: 'Custom',
+        displayName: 'Other',
         docsUrl: 'https://datahubproject.io/docs/metadata-ingestion/',
         logoComponent: <FormOutlined style={{ color: ANTD_GRAY[8], fontSize: 28 }} />,
     },
Original file line number	Diff line number	Diff line change
Expand Up		@@ -256,4 +256,4 @@ export const RECIPE_FIELDS: RecipeFields = {

		export const CONNECTORS_WITH_FORM = new Set(Object.keys(RECIPE_FIELDS));

		export const CONNECTORS_WITH_TEST_CONNECTION = new Set([SNOWFLAKE, LOOKER, BIGQUERY_BETA]);
		export const CONNECTORS_WITH_TEST_CONNECTION = new Set([SNOWFLAKE, LOOKER, BIGQUERY_BETA, BIGQUERY]);