Skip to content

Commit

Permalink
fix(smoke-tests) Increases sleep timeout in rollback test to prevent …
Browse files Browse the repository at this point in the history
…flakiness (#4979)
  • Loading branch information
pedro93 authored May 24, 2022
1 parent 669160a commit 483f66e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions smoke-test/tests/cli/datahub-cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_setup():

ingested_dataset_run_id = ingest_file_via_rest("tests/cli/cli_test_data.json").config.run_id
print("Setup ingestion id: " + ingested_dataset_run_id)
sleep(2)
sleep(5)

assert "browsePaths" in get_aspects_for_entity(entity_urn=dataset_urn, aspects=["browsePaths"], typed=False)

Expand All @@ -41,7 +41,7 @@ def test_setup():

session.post(rollback_url, data=json.dumps({"runId": ingested_editable_run_id, "dryRun": False, "hardDelete": True}))
session.post(rollback_url, data=json.dumps({"runId": ingested_dataset_run_id, "dryRun": False, "hardDelete": True}))
sleep(2)
sleep(5)

assert "browsePaths" not in get_aspects_for_entity(entity_urn=dataset_urn, aspects=["browsePaths"], typed=False)
assert "editableDatasetProperties" not in get_aspects_for_entity(entity_urn=dataset_urn, aspects=["editableDatasetProperties"], typed=False)
Expand Down Expand Up @@ -75,7 +75,7 @@ def test_rollback_editable():
session.post(rollback_url, data=json.dumps({"runId": ingested_dataset_run_id, "dryRun": False, "hardDelete": False}))

# Allow async MCP processor to handle ingestions & rollbacks
sleep(2)
sleep(5)

# EditableDatasetProperties should still be part of the entity that was soft deleted.
assert "editableDatasetProperties" in get_aspects_for_entity(entity_urn=dataset_urn, aspects=["editableDatasetProperties"], typed=False)
Expand Down

0 comments on commit 483f66e

Please sign in to comment.