Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial DDS support #1092

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Add initial DDS support #1092

merged 3 commits into from
Sep 2, 2020

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Aug 31, 2020

Creates a service extension, _yieldControlToDDS, which always returns
Success. This extension should place DWDS in single client mode so VM
service clients are required to connect through DDS.

See #1091

@bkonyi
Add initial DDS support
ccf9e73 
Creates a service extension, `_yieldControlToDDS`, which always returns
`Success`. This extension should place DWDS in single client mode so VM
service clients are required to connect through DDS.

See #1091
@bkonyi bkonyi requested a review from grouma August 31, 2020 20:41
@grouma
Copy link
Member

grouma commented Aug 31, 2020

I don't think we should return success until this is properly handled. We should be able to keep track of connected clients in the debug service. The connection is initiated here if it is SSE and here if it is a websocket.

@bkonyi
Copy link
Collaborator Author

bkonyi commented Sep 1, 2020

I don't think we should return success until this is properly handled. We should be able to keep track of connected clients in the debug service. The connection is initiated here if it is SSE and here if it is a websocket.

Thanks for pointing out where this should be implemented. I've updated the PR with a single client mode implementation.

grouma
grouma approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a changelog entry. Otherwise LGTM.

@bkonyi bkonyi merged commit 0797b56 into master Sep 2, 2020
@bkonyi bkonyi deleted the initial_dds_support branch September 2, 2020 02:10
@elliette elliette mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkonyi @grouma