-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note regarding synchronous communication between too many isolates #6182
Merged
MaryaBelanger
merged 12 commits into
dart-lang:main
from
aam:comment-on-limit-concurrency
Nov 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a654eca
Add note regarding synchronous communication between too many isolates
aam 6f18be3
Clean up
aam 434eeb4
Concurrent vs parallel, added 'unless...'
aam 335c807
Fix url links
aam 8a902ad
Use site variable
aam 1766a28
Fix url links again
aam 89162f2
Move text around
aam 250255c
Merge branch 'main' into comment-on-limit-concurrency
aam beed89f
rewrite/restructure
MaryaBelanger c0c61bc
Merge branch 'main' into comment-on-limit-concurrency
MaryaBelanger a578081
fix typos, links
MaryaBelanger 473bf61
aam reviews
MaryaBelanger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add note regarding synchronous communication between too many isolates
- Loading branch information
commit a654ecace4d8528faa4be1a102008ca6d062978c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase this as
"""
Synchronous blocking communication between isolates.
If isolates want to communicate synchronously they have to leave the safety of Dart and resort to using C code via FFI to do so. Special care must be taken in this circumstance due to the Dart VM imposing a limit on the number of isolates that can run in parallel. If the number of isolates that synchronously block in FFI calls exceeds that limit no other isolate can run. If those blocking isolates wait on another unscheduled isolate to act, then deadlock can occur. To avoid this situation (preventing other isolates from running & possibly deadlock scenarios) such blocking C code must take care of leaving the current isolate before performing the blocking operation and re-entering the isolate before returning from the FFI call (see ...)
"""
(especially concurrently -> in parallel - we can run thousands of isolates concurrently but not in parallel, i.e. at the same time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text sounds good, but did you mean for it to replace my version or you thought about adding it?