-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain pub get --enforce-lockfile
#6108
Conversation
Visit the preview URL for this PR (updated for commit fb416f3): https://dart-dev--pr6108-explain-enforce-lockfile-5x58srl2.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; from my perspective.
Not sure if it should be structured some other way -- it is a long :::note
.
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@sfshaza2 feel free to land if you are happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great documentation and advice @sigurdm! Thanks so much and sorry about the delay in reviewing this :D
The change mostly looks good to me, I just have a few questions and some optional suggestions to consider. Sorry if I got a bit rambly...
Also, if you are planning to link to this advice from tools, do consider adding a /to/
tooling redirect from the firebase.json
. Something like:
{ "source": "/to/enforce-lockfile", "destination": "/guides/packages#get-dependencies-for-production", "type": 301 },
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Good idea, done |
Not rambling at all, all the comments had great value! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for those adjustments @sigurdm! Looks great :D
…e-lockfile` (#6192) Follow-up to #6108 dart-lang/pub#4093 --------- Co-authored-by: Marya <[email protected]>
dart-lang/pub#4093