Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain pub get --enforce-lockfile #6108

Merged
merged 21 commits into from
Oct 3, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 25, 2024

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Sep 26, 2024

Visit the preview URL for this PR (updated for commit fb416f3):

https://dart-dev--pr6108-explain-enforce-lockfile-5x58srl2.web.app

Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; from my perspective.

Not sure if it should be structured some other way -- it is a long :::note.

src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
sigurdm and others added 5 commits September 27, 2024 08:28
@sigurdm
Copy link
Contributor Author

sigurdm commented Sep 27, 2024

@sfshaza2 feel free to land if you are happy.

@parlough parlough self-requested a review September 30, 2024 19:54
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great documentation and advice @sigurdm! Thanks so much and sorry about the delay in reviewing this :D

The change mostly looks good to me, I just have a few questions and some optional suggestions to consider. Sorry if I got a bit rambly...

Also, if you are planning to link to this advice from tools, do consider adding a /to/ tooling redirect from the firebase.json. Something like:

{ "source": "/to/enforce-lockfile", "destination": "/guides/packages#get-dependencies-for-production", "type": 301 },

src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
@sigurdm
Copy link
Contributor Author

sigurdm commented Oct 3, 2024

Also, if you are planning to link to this advice from tools, do consider adding a /to/ tooling redirect

Good idea, done

@sigurdm
Copy link
Contributor Author

sigurdm commented Oct 3, 2024

Not rambling at all, all the comments had great value!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for those adjustments @sigurdm! Looks great :D

@parlough parlough merged commit 6f11311 into dart-lang:main Oct 3, 2024
10 checks passed
MaryaBelanger added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants