Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-link for dart.dev/go/downgrade-testing #5872

Merged
merged 2 commits into from
May 31, 2024
Merged

Short-link for dart.dev/go/downgrade-testing #5872

merged 2 commits into from
May 31, 2024

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented May 27, 2024

For use in pana output on pub.dev (scoring page)

image

@jonasfj
Copy link
Member Author

jonasfj commented May 27, 2024

Blocked until #5838 lands.

@jonasfj jonasfj requested a review from parlough May 27, 2024 12:11
@jonasfj jonasfj mentioned this pull request May 27, 2024
Merged
@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit cce0b79):

https://dart-dev--pr5872-jonasfj-patch-1-o23dcsba.web.app

parlough
parlough approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to land when ready.

Optionally, do consider something like /go/pub-downgrade-testing or /go/package-downgrade-testing to make it more clear it's about package versions rather than SDK versions.

@jonasfj
Copy link
Member Author

jonasfj commented May 28, 2024

I don't mind using either:

  • /go/pub-downgrade-testing or,
  • /go/package-downgrade-testing

But:

  • (A) I think when we present the link to the user, in the context of a pana report about downgrade testing, pub- or package- is going to be unnecessary. It'll be clear to the user that we're talking about something to do with packages. So from that perspective I don't think we need it.
  • (B) I don't think that there is a huge risk we'll end up conflicting with other future go-links.

So all we'd do is making the short-link longer 🤣

@parlough
Copy link
Member

Makes sense! Keeping the shorter link works for me :)

@atsansone atsansone merged commit 4a4aec3 into main May 31, 2024
10 checks passed
@jonasfj jonasfj deleted the jonasfj-patch-1 branch May 31, 2024 08:16
@MaryaBelanger
Copy link
Contributor

@atsansone this was dependent on another PR (the section doesn't exist yet) as stated in an earlier comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryaBelanger MaryaBelanger MaryaBelanger approved these changes

@parlough parlough parlough approved these changes

@sigurdm sigurdm sigurdm approved these changes

Assignees

@jonasfj jonasfj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonasfj @dart-github-bot @parlough @MaryaBelanger @sigurdm @atsansone