Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mostly empty tutorials and codelabs section from sidenav #5858

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Remove mostly empty tutorials and codelabs section from sidenav #5858

merged 8 commits into from
Jun 10, 2024

Conversation

parlough
Copy link
Member

  • Supersedes Initial attempt at combining tutorials and codelabs #4875 to make way for new getting started content.
  • Begins consolidating the idea of "codelab" and "tutorial", for a future where we drop codelabs from the site.
  • Add codelabs and tutorial not already in sidenav elsewhere to the sidenav.
  • Keep tutorial index, but put it in under resources.

Closes #4875

@parlough parlough added the review.copy Awaiting Copy Review label May 22, 2024
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented May 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5b1c38c):

https://dart-dev--pr5858-feat-remove-codelabs-tutorials-top-le-aihyjab5.web.app

@atsansone
Copy link
Contributor

/gcbrun

@atsansone atsansone mentioned this pull request May 31, 2024
Closed
atsansone
atsansone reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parlough : Let's retire Codelab in these docs entirely. A Codelab is a Google-branded tutorial format, but a tutorial is not a Codelab. Once you make these changes, I'll approve.

src/content/resources/coming-from/js-to-dart.md Outdated Show resolved Hide resolved
src/content/resources/coming-from/js-to-dart.md Outdated Show resolved Hide resolved
src/content/tutorials/index.md Outdated Show resolved Hide resolved
src/content/tools/dartpad/index.md Outdated Show resolved Hide resolved
src/content/tutorials/index.md Show resolved Hide resolved
src/content/tutorials/server/get-started.md Outdated Show resolved Hide resolved
src/content/web/get-started.md Outdated Show resolved Hide resolved
src/_data/side-nav.yml Outdated Show resolved Hide resolved
src/_data/side-nav.yml Outdated Show resolved Hide resolved
src/content/codelabs/iterables.md Outdated Show resolved Hide resolved
@atsansone atsansone assigned parlough and unassigned MaryaBelanger Jun 3, 2024
@atsansone atsansone added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Jun 3, 2024
@atsansone atsansone mentioned this pull request Jun 4, 2024
Merged
parlough
parlough commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @atsansone!

I went ahead and moved away from the "Codelab" term more. Note that the goal is to sooner than later supersede all three of the remaining codelabs, so I'd prefer to keep the file location the same for now to avoid too much unnecessary shuffling and redirects. Let me know if you have any concerns though. Thanks!

src/_data/side-nav.yml Outdated Show resolved Hide resolved
src/_data/side-nav.yml Outdated Show resolved Hide resolved
@parlough parlough removed the review.await-update Awaiting Updates after Edits label Jun 6, 2024
@parlough parlough removed their assignment Jun 6, 2024
@parlough parlough requested a review from atsansone June 6, 2024 05:51
@atsansone atsansone added the st.RFM.% Ready to Merge but has suggestions label Jun 7, 2024
@atsansone atsansone assigned parlough and unassigned atsansone Jun 10, 2024
MaryaBelanger
MaryaBelanger reviewed Jun 10, 2024
View reviewed changes
src/content/tutorials/index.md Outdated Show resolved Hide resolved
src/_data/side-nav.yml Outdated Show resolved Hide resolved
src/content/tutorials/index.md Show resolved Hide resolved
src/_data/side-nav.yml Outdated Show resolved Hide resolved
@parlough parlough removed their assignment Jun 10, 2024
@parlough parlough removed the st.RFM.% Ready to Merge but has suggestions label Jun 10, 2024
@parlough parlough merged commit b2b5c71 into main Jun 10, 2024
10 checks passed
@parlough parlough deleted the feat/remove-codelabs-tutorials-top-level branch June 10, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryaBelanger MaryaBelanger MaryaBelanger left review comments

@atsansone atsansone atsansone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parlough @dart-github-bot @atsansone @MaryaBelanger