Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some content out of deprecated /guides directories #5769

Merged
merged 4 commits into from
May 6, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented May 4, 2024

Contributes to #5767 and #4565 by moving a few isolated pages within the /guides directory that have an existing suitable location to there.

These are grouped as an initial step as they don't require larger content or restructuring changes, unlike some other pages within the /guides directory.

Original location New location
/guides/libraries/useful-libraries /resources/useful-packages
/guides/libraries/writing-package-pages /tools/pub/writing-package-pages
/guides/google-apis /resources/google-apis
/guides/language/coming-from/** /resources/coming-from/**

@parlough parlough added the review.copy Awaiting Copy Review label May 4, 2024
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented May 4, 2024

Visit the preview URL for this PR (updated for commit d24e42d):

https://dart-dev--pr5769-misc-deprecated-folder-cleanup-t73ac0l2.web.app

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parlough : If you aren't getting a 1:1 of issue to PR, consider how you're framing the issue or developing the PR. Highly recommend making either smaller scope issues or completing whole issues in one PR.

@atsansone atsansone added st.RFM.% Ready to Merge but has suggestions and removed review.copy Awaiting Copy Review labels May 6, 2024
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @atsansone re:mismatched issue/pr, but I think the problem here is mostly on me for writing these sweeping issues that do need to be broken down to tackle.

I'd say the solution for this kind of thing ("Contributes to #issue"), besides me writing better issues 🙃, would be a little more description in the PR summary about what parts of the mentioned issues this contributes to, how does that sound? That way at least we can go edit the issue description and cross some parts out if they're done. Just a thought!

@parlough parlough removed the st.RFM.% Ready to Merge but has suggestions label May 6, 2024
@parlough
Copy link
Member Author

parlough commented May 6, 2024

Thanks for the reviews and feedback!

I didn't see this as an isolated piece of work/issue and it could technically all be in one larger PR later, but just ends up being easier to review in a few small PRs.

I added more details as well as a list of changes to this PRs description and will make sure to do so as well next time :)

@parlough parlough merged commit 8f9e82e into main May 6, 2024
10 checks passed
@parlough parlough deleted the misc/deprecated-folder-cleanup branch May 6, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants