Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /macros redirect to current language spec #5684

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add /macros redirect to current language spec #5684

merged 1 commit into from
Apr 3, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Apr 3, 2024

In the (near) future this can be updated to point to a getting started
guide or similar

@kevmoo
Add /macros redirect to current language spec
13a883c 
In the (near) future this can be updated to point to a getting started
guide or similar
@kevmoo kevmoo requested a review from johnpryan April 3, 2024 22:46
@kevmoo
Copy link
Member Author

kevmoo commented Apr 3, 2024

CC @mit-mit @munificent @jakemac53

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 13a883c):

https://dart-dev--pr5684-macros-redirect-z64ditnj.web.app

parlough
parlough approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a one-off, but long-term I'd prefer to implement a proper solution for sharing WIP features/specs rather than filling up the top-level scope: #5079

@kevmoo
Copy link
Member Author

kevmoo commented Apr 3, 2024

This is fine as a one-off, but long-term I'd prefer to implement a proper solution for sharing WIP features/specs rather than filling up the top-level scope: #5079

If this was JUST for the spec, yes, but the theory is that this link will evolve to point to a wiki page for getting started with the preview to the eventual https://dart.dev/language/macoros or whatever page we want to have in the end.

@parlough
Copy link
Member

parlough commented Apr 3, 2024

If this was JUST for the spec, yes, but the theory is that this link will evolve to point to a wiki page for getting started with the preview to the eventual https://dart.dev/language/macoros or whatever page we want to have in the end.

Sounds good to me :)

@parlough parlough merged commit 6bab186 into main Apr 3, 2024
9 checks passed
@parlough parlough deleted the macros_redirect branch April 3, 2024 23:03
@mit-mit mit-mit mentioned this pull request Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@johnpryan johnpryan johnpryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevmoo @dart-github-bot @parlough @johnpryan