Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate formatting pages #5387

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Consolidate formatting pages #5387

merged 5 commits into from
Dec 4, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Dec 1, 2023

We have different issues open tracking other improvements to the page.

Fixes #5091

Staged: https://dart-dev--pr5387-fix-5091-e1vuf1lg.web.app/tools/dart-format

Copy link

github-actions bot commented Dec 1, 2023

Visit the preview URL for this PR (updated for commit f2258ad):

https://dart-dev--pr5387-fix-5091-e1vuf1lg.web.app

(expires Fri, 08 Dec 2023 22:02:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@parlough parlough added the review.copy Awaiting Copy Review label Dec 1, 2023
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments, thanks!

Comment on lines 312 to 313
- title: What not to commit
permalink: /guides/libraries/private-files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the only child page of Managing source code now, what do you think of getting rid of that category and moving What not to commit up a level in the side nav? Might look kind of clunky/random next to the other sections up "Tools and techniques", but I think it's better than the wasted section for now

src/tools/dart-format.md Outdated Show resolved Hide resolved
@parlough parlough removed the review.copy Awaiting Copy Review label Dec 1, 2023
@parlough parlough merged commit 96d527b into main Dec 4, 2023
9 checks passed
@parlough parlough deleted the fix/5091 branch December 4, 2023 22:11
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
We have different issues open tracking other improvements to the page.

Fixes dart-lang#5091

---------

Co-authored-by: Marya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate formatting pages
2 participants