-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate formatting pages #5387
Conversation
Visit the preview URL for this PR (updated for commit f2258ad): https://dart-dev--pr5387-fix-5091-e1vuf1lg.web.app (expires Fri, 08 Dec 2023 22:02:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments, thanks!
src/_data/side-nav.yml
Outdated
- title: What not to commit | ||
permalink: /guides/libraries/private-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the only child page of Managing source code
now, what do you think of getting rid of that category and moving What not to commit
up a level in the side nav? Might look kind of clunky/random next to the other sections up "Tools and techniques", but I think it's better than the wasted section for now
We have different issues open tracking other improvements to the page. Fixes dart-lang#5091 --------- Co-authored-by: Marya <[email protected]>
We have different issues open tracking other improvements to the page.
Fixes #5091
Staged: https://dart-dev--pr5387-fix-5091-e1vuf1lg.web.app/tools/dart-format