Deconstruct library tour #5367
Deconstruct library tour #5367
Conversation
|
Visit the preview URL for this PR (updated for commit f1b5ed3): https://dart-dev--pr5367-library-tour-mqpt3qxg.web.app (expires Mon, 25 Dec 2023 23:13:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
|
Thanks for taking this over and doing all the heavy lifting with the redirects @parlough! I picked a handful of links around the site to test and everything looks good. The layout makes sense to me too. If you want to move https://dart.dev/codelabs/async-await and https://dart.dev/tutorials/language/streams up to your new "library guides" section, you can go ahead and do that. Either way, consider this "approved" by me! |
There was a problem hiding this comment.
Deferring to @MaryaBelanger's review in #5367 (comment) since I took over ownership of this PR.
Thanks for starting this and reviewing it! I moved the using streams article up too :)
This PR breaks up the library tour to facilitate more content living under "Core libraries" in the future and users being able to access what is important to them more easily. The change is implemented in a similar fashion to the language tour split up. The following work was completed: - Introduced a new top-level `/libraries` folder - Combined the index at `/guides/libraries` and the intro to the library tour at `/libraries/index`. - Split each section of the library tour in to their own page - Add each new page to the sidenav under "Core libraries" - Add a redirector on the old page to redirect accesses to specific headings to the correct new page and heading - Add previous and next buttons to the various pages - Update links across the entire website - Add and update redirects where necessary Fixes dart-lang#4610 --------- Co-authored-by: Parker Lougheed <[email protected]>
This PR breaks up the library tour to facilitate more content living under "Core libraries" in the future and users being able to access what is important to them more easily.
The change is implemented in a similar fashion to the language tour split up. The following work was completed:
/librariesfolder/guides/librariesand the intro to the library tour at/libraries/index.Fixes #4610