-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New JS interop docs #4578
New JS interop docs #4578
Conversation
commit 9895fb6 :
@srujzs That was the last of my input, you can take this over any time now! Let me know if you need anything else. |
Nice, thanks for the help! Just a quick question when I iterate in the future: is there a way to see the web page after uploading a new commit? I tried the previous links but I don't think they use the newer commits. |
@srujzs Normally it's supposed to generate a few minutes after a commit and pop up on its own, but I think because the build / stage check is not passing, it's not doing it. I tried to fix the link issues it's pointing to... not sure why they're still popping up... Anyways to generate the shareable staging link yourself, follow these steps https://github.com/dart-lang/site-www#deploying-to-a-staging-site . It's what I always do when my builds failing for whatever reason. The only out-of-terminal part is creating a project in the firebase console site, after that you can keep reusing the same project every time you want to restage. I think @parlough is out for a little while, but when he's back he might have better advice. |
Fyi: I just came across these two DOM tutorials, pretty sure they're not related to this work but just in case check them out: |
Oooh, I either forgot or didn't know these existed. These are good candidates for a tutorial using interop instead of dart:html. |
@srujzs Great, if you end up deciding to rewrite those pages themselves (I guess if their contents are no longer relevant with static interop, or if they're just not practices we want to promote anymore), or if you just create new pages. Just so I can move/remove the old ones (this can be decided at the very end so rush) @sigmundch re: this comment. This makes me wonder, though, should these docs come out with the .0 release or the .1 release? I assumed that we wouldn't release these docs until static interop comes out (.1), but if users are already using and getting errors maybe we can just publish this stuff as soon as its ready, and just note on every page, maybe with a banner, that this is not in stable yet? |
The content is still relevant in those pages as it's modifying the DOM in a simple, core way. We'd likely want to rewrite that using Re: versioning, agreed we want both. We can make the docs reflect the current status when it's time to release 3.0, and once issues have been resolved and we're ready for a more stable release, we can edit them then. The above issues is relevant to JS interop in general so I don't think versioning there matters much. We can add a FAQ section for stuff like that whenever since the issue already exists. |
remove broken link add tutorial outline restructure new pages left out of last commit
6e989f3
to
b6ddf73
Compare
Visit the preview URL for this PR (updated for commit 9dadda6): |
Note I merged |
Also addresses some review comments and removes old pages that are irrelevant now.
Needed for the site index for now.
TODO
Fyi @srujzs I'm sure you're in the middle of some commits so you can throw these in if you want, or I can take care of it after you land your next commit/whenever your done. Just lmk! Edit: the go link is here: https://github.com/dart-lang/site-www/blob/main/firebase.json#L175
|
The extension types page is merged, so you can uncomment any links to |
Also cleans up some TODOs.
Done! The failure in links is expected because we link to We also should remove |
Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Srujan Gaddam <[email protected]> Co-authored-by: sigmundch <[email protected]>
Congrats to you both on landing this and thanks so much for working on it! It's super exciting, and more + better JS-interop documentation than we've ever had. Developers will appreciate and benefit greatly from it! Sorry I haven't been able to give it too close of a look yet, but I promise I will. |
Fixes dart-lang#5438 --------- Co-authored-by: Srujan Gaddam <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: sigmundch <[email protected]>
Fixes #5438
WIP (lots of notes interspersed on the pages)
Adds new pages and content to cover static, inline-class based, JS interop.
Staged: https://dart-dev--pr4578-js-interop-jct9fv7o.web.app/interop/js-interop
New pages: