Use .dart_tool/pub as the cache directory #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were in separate files for infrastructure reasons that no longer apply.
|
If we're really going to run with this
CC @kwalrath |
Pub will continue to read cached files from .pub if it exists. Any time it modifies the cache, it will migrate .pub to .dart_tool/pub. Closes #1795
natebosch
approved these changes
Feb 2, 2018
| @@ -133,15 +133,26 @@ class Entrypoint { | |||
| /// The path to the entrypoint package's lockfile. | |||
| String get lockFilePath => root.path('pubspec.lock'); | |||
|
|
|||
| /// The path to the entrypoint package's `.dart_tool/pub` cache directory. | |||
| /// | |||
| /// If the old-style `.pub` directory is being used, this returns that | |||
There was a problem hiding this comment.
👍 nice way to ease the transition
|
Moved my comment to dart-lang/sdk#32030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.