This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Merge null safety branch into master #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily this is just removing a bunch of dynamic params and converting them to Object, and then removing some of the explicit tests around null args that are no longer valid statically in the test. Note that the runtime argument errors are still present, and I left the tests in for argumentErrorTest which effectively validates the non-opted in users calling these functions still get the same behavior. We could restore some of the other tests that I deleted to do a similar thing, if we think its worth while.
|
To fix CI, update CI SDK then use |
|
also need to enable the expeeriment w/ analyzer CLI |
|
Looks like we need to migrate a few more packages for web tests to work |
|
And this is probably a package where that is important haha |
|
Wonder why travis status isn't showing up (for me) https://travis-ci.org/github/dart-lang/fixnum/builds/696895050 |
|
there it is! |
|
@kevmoo I can haz lgtm? |
🤘
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
* migrate fixnum to null safety (dart-archive/fixnum#55) Primarily this is just removing a bunch of dynamic params and converting them to Object, and then removing some of the explicit tests around null args that are no longer valid statically in the test. Note that the runtime argument errors are still present, and I left the tests in for argumentErrorTest which effectively validates the non-opted in users calling these functions still get the same behavior. We could restore some of the other tests that I deleted to do a similar thing, if we think its worth while.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is reasonable to just merge this one, and then the SDK can more safely depend on it.
This package is unlikely to get non-nnbd related commits before we release.