This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Address pedantic lints #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Dec 10, 2019
| for (int i = 0; i < s.length; i++) { | ||
| int c = s.codeUnitAt(i); | ||
| int digit = _decodeDigit(c); | ||
| var x = ZERO; |
There was a problem hiding this comment.
nit: I'd be tempted to leave just this one. It's relatively obvious given the constant but maybe a good reminder to the reader given it's the odd one out here and line 62. Not the end of the world given every other var in this file looks fine to me.
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
* Update int64.dart * Update analysis_options.yaml * Update int32.dart * Update int64.dart * Update int32.dart * Update int32.dart * Update intx.dart * Update int32.dart * Update all_tests.dart * Update int32_test.dart * Update pubspec.yaml * Update int_64_vm_test.dart * Update int64_test.dart * Update int64_test.dart * Update int64_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.