update wiki user talk highlighting #13540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with message highlighting in user talks on wikipedia
updated the color again to something that will work across more message types
Contributor
Author
|
I would welcome other suggestions for coloring or no coloring |
Collaborator
|
I tried to make the color not related to variable and I think the closest one to original is to use It looks nice in Dark scheme and light scheme of Dark Reader. Check if you confirm and if you like this then push this code to PR and I will merge. If not then try to find different color. 😉 |
Myshor
requested changes
Nov 25, 2024
Collaborator
Myshor
left a comment
Myshor
left a comment
There was a problem hiding this comment.
The result with this code is not very nice. Check my comment.
improves the original color correction to a light purple that is easier on the eyes
Contributor
Author
I think it looks much better now |
Myshor
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue with message highlighting in user talks on Wikipedia. Users receive notifications about messages on their user talk, clicking the notification brings them to the user talk where the message is highlighted.
Why
DR does not properly highlight the message. Disabling the color would prevent all message highlighting, and the default coloring on Wikipedia is a harsh white background. Recommend using one of the special DR background color variables.
Examples
Link with an example of it working: https://en.wikipedia.org/wiki/User_talk:PolyversialMind/Archive_1#c-Lajmmoore-20240523070600-Women_in_Red_June_2024
(highlighting disappears when you click elsewhere on page)
Before:
https://i.imgur.com/MlerCFV.png
After:
https://i.imgur.com/vrnyXYK.png