Skip to content

Conversation

@JNylson
Copy link

@JNylson JNylson commented Nov 20, 2024

No description provided.

@Myshor
Copy link
Collaborator

Myshor commented Nov 21, 2024

The idea is nice as the new design is mostly not translated in many places but making review of it will take much time I think.

First look is it's ok. At least we have added all necessary variables into tranlation files. All of them are in English here but that means it will work the same as it was before without variables.

What is needed to be checked - all places where static text was changed to variable to be sure we don't have some typo in code.

Again today I will call @alexanderby as I do not know how the future plans for Dark Reader look like and if the new design will be default in the future or there will be total change of design so this PR would not be needed.

@alexanderby
Copy link
Member

You did a big chunk of work. But the problem now is this list of translations is hardly maintainable. And the design planned is totally different. Let me think how I can improve the structure of the translations files, and I will get back to you.

Currently, please move changes to existing Portuguese translations for old design into a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants