Add Valve-related sites to global dark list #13097
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Except l4d.com I have doubts the rest should be added to dark list as they are not dark, and Dark Reader makes some cosmetic changes there. portal2 page could be accepted as it looks strange but halflife makes some texts back to black. I won't merge it. Let @alexanderby decides. |
Contributor
Author
|
Half-life 25 years page has some problems with dark reader on (such as text going black and some missing background features). I believe it's ok to add an exception to that specific page, because with dark reader OFF the page looks fine IMO (not too bright). For thinkwithportals your argument is valid and I respect it. |
Collaborator
|
I am strict about pages that are not fully dark. That's why I called Alexander here. 😉 |
Contributor
Author
|
friendly ping @alexanderby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
half-life.comlooks fine with Dark Reader, but the special subpagehalf-life.com/*/halflife25has some problems with Dark Reader ON, and it can be disabled specifically for that page.*here is for language (/en/,/fr/etc.).l4d.comis already dark.thinkwithportals.comis already dark, except for the background, but enabling Dark Reader there defeats the site purpose's of resembling the in-game levels.