Skip to content

Conversation

@ccwaddey
Copy link

@ccwaddey ccwaddey commented May 6, 2024

This makes images on a site that my company uses for work more readable in dark mode. It also makes selection boxes readable. Since this is a private access website, I understand if this won't be accepted, but I'm not sure how to make the changes automatically apply when I open up the site for the first time without having to go into dev tools and apply them there. Other users of the site at my company would appreciate this very much, since not everyone is technical enough to figure this out. Let me know if you want pictures of how this looks in dark mode and light mode, or if you need anything else.

This makes images on a site that my company uses for work more readable in dark mode. It also makes selection boxes readable. Since this is a private access website, I understand if this won't be accepted, but I'm not sure how to make the changes automatically apply when I open up the site for the first time without having to go into dev tools and apply them there. Other users of the site at my company would appreciate this very much, since not everyone is technical enough to figure this out. Let me know if you want pictures of how this looks in dark mode and light mode, or if you need anything else.
@ccwaddey
Copy link
Author

ccwaddey commented May 6, 2024

Here are some before and after screenshots of what I'm talking about:
before:
image
after:
image

@ccwaddey
Copy link
Author

ccwaddey commented May 6, 2024

And for the selections:
before:
image
after:
image

@ccwaddey
Copy link
Author

ccwaddey commented May 6, 2024

And feel free to remove the img CSS selector from this. I don't know why that's in there and it looks a lot cleaner without it.

Copy link
Member

@alexanderby alexanderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the URL is accessible through internet I see no issues accepting this PR, after non-static colors are used.

This uses darkreader variables for colors instead of hard coded ones and adds some CSS to make the select arrows visible in certain forms that otherwise are not visible in dark mode.
@ccwaddey ccwaddey requested a review from alexanderby May 7, 2024 19:42
This increases the specificity of the images to invert by only inverting those that are sourced from a graph-like url.
@ccwaddey ccwaddey requested a review from alexanderby May 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants