Fixed logo's for Future-brand sites #12618
Conversation
Fixes SVG elements on Future-brand sites, includes mostly site logo's and some other icons.
| #slice-container-subBrandsBar > div > a > span > svg > path:nth-child(2) | ||
|
|
||
| IGNORE INLINE STYLE | ||
| .site-logo svg * |
There was a problem hiding this comment.
Let's try solving it a bit differently. Let's try putting something like
*
IGNORE INLINE STYLE
svg[role="img"] path
svg[role="img"] g
svg[role="img"] rect
svg[role="img"] circle
// Maybe 'svg[role="img"] *' will work, but not sure about performance
and the other fixes should be just INVERT when necessary.
|
Please stick to my proposal, or hold on, as far as I've got some ideas on improving the SVG analysis. The list of the websites and the wrong elements is very useful for testing, thank you. |
|
I made a fix for SVG logos. Seems working mostly fine (except of iMore, where the logo styles come from different sources). The fix should be available next week. |
|
Version 4.9.84 is available, please check it out. UPD: false start, I guess in's a holiday in Germany and Mozilla is not ready to review it yet. |
|
I'm on Chromium so was able to test the changes in 4.9.84. Blue textAs previously discussed in #12613, re-tested and the issue with blue text has been fixed ✅ SVG Logo's90% of these site logo's now have the correct invert. But every logo whilst loading flashes as at first they're not inverted, causing a distracting change once loaded. Recording.2024-05-02.001358.mp4This wasn't the case with my original fixes, which worked by not targeting the SVG directly, instead it's sub elements. Either with a wildcard or the name of the SVG elements. Recording.2024-05-02.001757.mp4Remaining logo invert issues with: Also, https://www.imore.com but that's just impossible to invert correctly. Instead, probably still need to use the kind of manual changes I made specifically for this one, might be best if it ends up in another pr. Other SVG logo'sThese websites have sub-brand sites, and use their logo's in the navigation, still an issue. SVG social iconsAll of the sites still have an issue with the twitter/X share icon: @alexanderby Let me know if you want to try and fix any of these issues at the app level again. Otherwise I can try targeted fixes. |
|
Thanks for noticing the blink, I made a fix. I will think what to do with other isues. |
|
I'm going to close this PR since it's been open a long time without movement; I feel someone else would be better placed to tackle the original issue if they'd like to see it fixed. |
2 participants
Fixes multiple SVG elements and related problems on Future-brand sites. Includes mostly changes to the site's logo's and some other icons.
Example before:
Example after:
Notes
This is a continuation of my original fix #12613 for pcgamer.com. As other Future-branded sites raised in #12507 also needed fixing.
Additional fixes relating to CSS layers have already been merged 7bdf63e.
Site list: