Add support for .NET Framework packages.config (OctoLinker#367)

Example: https://github.com/olsh/resharper-configuration-sense/blob/dacf88b8264909dbfe10613197ec8302b05542b0/src/Resharper.ConfigurationSense/packages.config
danielarantes · Jun 5, 2017 · 8b25456 · 8b25456
1 parent 02c0d06
commit 8b25456
Show file tree

Hide file tree

Showing 7 changed files with 67 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -95,6 +95,9 @@ OctoLinker is the easiest and best way to navigate between files and projects on
 - `dependencies`
 - `tools`
 
+### packages.config (.NET Framework)
+- `<package id="..." />`
+
 ### Go
 - `import`
 

diff --git a/lib/plugins/dot-net-core.js b/lib/plugins/dot-net-core.js
@@ -1,6 +1,7 @@
 import processJSON from './helper/process-json';
 import { jsonRegExKeyValue } from './helper/regex-builder';
 import insertLink from '../insert-link';
+import nugetResolver from '../resolver/nuget';
 
 function linkDependency(blob, key, value) {
   const regex = jsonRegExKeyValue(key, value);
@@ -15,9 +16,7 @@ export default {
   name: 'DotNetCore',
 
   resolve({ target }) {
-    return [
-      `https://www.nuget.org/packages/${target}`,
-    ];
+    return nugetResolver({ target });
   },
 
   getPattern() {

diff --git a/lib/plugins/dot-net.js b/lib/plugins/dot-net.js
@@ -0,0 +1,21 @@
+import nugetResolver from '../resolver/nuget';
+import { NET_PACKAGE } from '../../packages/helper-grammar-regex-collection/index.js';
+
+export default {
+  name: 'DotNet',
+
+  resolve({ target }) {
+    return nugetResolver({ target });
+  },
+
+  getPattern() {
+    return {
+      pathPatterns: ['/packages.config$'],
+      githubClasses: [],
+    };
+  },
+
+  getLinkRegexes() {
+    return NET_PACKAGE;
+  },
+};
diff --git a/lib/resolver/nuget.js b/lib/resolver/nuget.js
@@ -0,0 +1,5 @@
+export default function ({ target }) {
+  return [
+    `https://www.nuget.org/packages/${target}`,
+  ];
+}
diff --git a/packages/helper-grammar-regex-collection/index.js b/packages/helper-grammar-regex-collection/index.js
@@ -130,3 +130,11 @@ export const HTML_IMPORT = regex`
   \s
   href=${captureQuotedWord}>
 `;
+
+export const NET_PACKAGE = regex`
+  <\s*
+  package
+  \s*
+  id=${captureQuotedWord}
+  .*/>
+`;
diff --git a/packages/helper-grammar-regex-collection/test.js b/packages/helper-grammar-regex-collection/test.js
@@ -370,6 +370,16 @@ const fixtures = {
       'import (\n"octo.com/foo/bar"\n)',
     ],
   },
+  NET_PACKAGE: {
+    valid: [
+      '<package id="foo" version="2.7.7.02" targetFramework="net45" />',
+      '< package id="foo" version="2.7.7.02" targetFramework="net45" />',
+    ],
+    invalid: [
+      '<packages id="Antlr2.Runtime" version="2.7.7.02" targetFramework="net45" />',
+      '<package version="2.7.7.02" targetFramework="net45" />',
+    ],
+  },
 };
 
 function fixturesIterator(fixturesList, next) {

diff --git a/test/plugins/dot-net.test.js b/test/plugins/dot-net.test.js
@@ -0,0 +1,18 @@
+import assert from 'assert';
+import dotNet from '../../lib/plugins/dot-net';
+
+describe('dotNet', () => {
+  it('resolves EntityFramework to https://www.nuget.org/packages/EntityFramework', () => {
+    assert.deepEqual(
+      dotNet.resolve({ target: 'EntityFramework' }),
+      ['https://www.nuget.org/packages/EntityFramework'],
+    );
+  });
+
+  it('resolves Stanford.NLP.CoreNLP to https://www.nuget.org/packages/Stanford.NLP.CoreNLP', () => {
+    assert.deepEqual(
+      dotNet.resolve({ target: 'Stanford.NLP.CoreNLP' }),
+      ['https://www.nuget.org/packages/Stanford.NLP.CoreNLP'],
+    );
+  });
+});