Address nightly-2024-05-05 warns
#652
Conversation
|
Is there an issue with emitting e.g. |
|
Yes it will result to MSRV check and it has a hard complaint to require bumping to 1.77 regardless if this is gated only to >= 1.77- fwiw I flagged this and asked whether it was intentional given bumping to MSRV 1.77 at 1.80 isn't always doable |
|
How does that actually manifest? Do older rusts complain about it? |
|
No the new versions complain that is the problem - where we actually would declare them and where it takes effect. |
|
Aah, I see now:
|
pinkforest
changed the title
pinkforest
changed the title
nightly-2024-05-05 warns
1.80 supposedly will and nightly (2024-05-05) has introduced cfg-check spitting out some warnings.
The problem is if we declare the cfg's as intended - this will then complain about MSRV despite where we would only print these flags when rustc is >= 1.77 a.k.a this feature hard-checks MSRV and then asks to bump MSRV 1.77 despite build.rs never using the feature as gated in build.rs for below <= 1.77 as checked - I've asked clarification whether this is intended.
In order to mitigate this we can just temporarily allow the status-quo and when MSRV jumps to 1.77 we can declare them when MSRV bumps to 1.77 - it seems we can still use them just fine without making MSRV check failing.
Also need to allow two occassions unnecessary qualification (group::ff) where when only group feature is used when ff is available directrly where as it's always available via group::ff - leading to lint complaining.
EDIT: The derive conditional one is cursed - need to check that later but it seems that lint there cannot be disabled for some reason - so temporarily just made it not complain as it was in test - need to double-check it