Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curve: mark ValidityCheck trait as allow(dead_code) #625

Merged
merged 1 commit into from
Feb 12, 2024
Merged

curve: mark ValidityCheck trait as allow(dead_code) #625

merged 1 commit into from
Feb 12, 2024

Conversation

tarcieri
Copy link
Contributor

Recent nightlies have started emitting a dead code lint which is breaking the build: https://github.com/dalek-cryptography/curve25519-dalek/actions/runs/7873600894/job/21481401663?pr=624#step:4:152

@tarcieri
curve: mark ValidityCheck trait as allow(dead_code)
6f92fbb 
Recent nightlies have started emitting a dead code lint
@tarcieri tarcieri requested a review from rozbb February 12, 2024 15:58
@tarcieri tarcieri mentioned this pull request Feb 12, 2024
Merged
rozbb
rozbb reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@rozbb rozbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change. One thought: would it make more sense for this to be #[cfg(test)]? It's not accessible outside the crate anyway so it won't bother external users

@tarcieri
Copy link
Contributor Author

tarcieri commented Feb 12, 2024 •
edited
Loading

Not sure that would fix it for the cargo test case, since it seems to actually be dead code. Per the comments, it's intended for debugging use, so it's not expected to have any usages.

Edit: notably the error here is occurring during cargo test: https://github.com/dalek-cryptography/curve25519-dalek/actions/runs/7873600894/job/21481401663?pr=624#step:4:152

@rozbb
Copy link
Contributor

rozbb commented Feb 12, 2024

Ah ok then

@rozbb rozbb merged commit 50401ab into main Feb 12, 2024
44 checks passed
@tarcieri tarcieri deleted the curve/validity-check-allow-dead branch February 12, 2024 16:58
mikelodder7 pushed a commit to mikelodder7/curve25519-dalek-ml that referenced this pull request Feb 17, 2024
@tarcieri @mikelodder7
curve: mark ValidityCheck trait as allow(dead_code) (dalek-crypto…
f870097 
…graphy#625)

Recent nightlies have started emitting a dead code lint
@tarcieri tarcieri mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozbb rozbb rozbb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarcieri @rozbb