Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_dm_to() and cyclic foreign key constraints #664

Open
krlmlr opened this issue Oct 13, 2021 · 1 comment · May be fixed by #2022
Open

copy_dm_to() and cyclic foreign key constraints #664

krlmlr opened this issue Oct 13, 2021 · 1 comment · May be fixed by #2022
Labels
debt Technical debt
Milestone

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Oct 13, 2021

A topo sort is now required in copy_dm_to() after #658, we should offer an escape hatch.

@krlmlr krlmlr added the debt Technical debt label Oct 13, 2021
@krlmlr krlmlr added this to the 0.2.5 milestone Oct 13, 2021
@krlmlr krlmlr removed this from the 0.2.5 milestone Oct 13, 2021
@krlmlr
Copy link
Collaborator Author

krlmlr commented Oct 13, 2021

The current behavior isn't perfect, but rather low priority.

krlmlr added a commit that referenced this issue Oct 16, 2021
dm 0.2.5

- `mutate()`, `transmute()`, `distinct()` and `summarize()` now support `dplyr::across()` and extra arguments (#640).
- Key tracking for the first three verbs is less strict and based on name equality (#663).
- `relocate()` now works on zoomed `dm` objects (#666).
- `dm_add_fk()` gains `on_delete` argument which `copy_dm_to()` picks up and translates to an `ON DELETE CASCADE` or `ON DELETE NO ACTION` specification for the foreign key (#649).
- `dm_copy_to()` defines foreign keys during table creation, for all databases except DuckDB. Tables are created in topological order (#658). For cyclic relationship graphs, table creation is attempted in the original order and may fail (#664).
- `waldo::compare()` shows better output for dm objects (#642).
- `dm_paste()` output uses trailing commas in the `dm::dm()` and `tibble::tibble()` calls, and sorts column attributes by name, for better modularity (#641).

- New `db_schema_create()`, `db_schema_drop()`, `db_schema_exists()` and `db_schema_list()` replace the corresponding `sql_schema_*()` functions, the latter are soft-deprecated (#670). The connection argument to `db_schema_*()` is called `con`, not `dest` (#668).

- `copy_dm_to()` and `sql_create_schema()` no longer actively check for schema existence (#644, #660).
- Add newline after `OUTPUT` clause for SQL Server (#647).
- Fix `sql_rows_delete()` with `returning` argument for SQL Server (#645).

- Remove method only needed for RSQLite < 2.2.8, add warning if loaded RSQLite version is <= 2.2.8 (#632).
- Adapt MSSQL tests to testthat update (#648).
@krlmlr krlmlr added this to the bluesky milestone Oct 18, 2021
@krlmlr krlmlr modified the milestones: bluesky, copy Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment