To add reconciliation time stamps #572
Conversation
|
@Abiji-2020 check the CI. Its failing on unused import |
UpdatesThere is a time package which was planned to use initally and then i have'nt used it so now i had removed it. |
|
How can i check for this checking as again tests in CI is failing? |
petar-cvit
left a comment
petar-cvit
left a comment
There was a problem hiding this comment.
@Abiji-2020 thanks for the PR and the description of your changes! Left two comments, but could you also format the code? I see a lot of changes coming from different indentation
|
The code was updated and the formatting was cleared |
petar-cvit
left a comment
petar-cvit
left a comment
There was a problem hiding this comment.
@Abiji-2020 thanks, looks good! 🧡
Will merge after #582
|
Hey @Abiji-2020, I tried running Cyclops from your branch one more time and found that Modules kept reconciling endlessly. The issue is that on each reconciliation, We need to change our reconciliation policy in order to include this PR and not trigger unnecessary reconciliations |
so What can we do now. Like modifications.? |
|
@Abiji-2020 yeah, I will make a PR that will introduce event filter so reconciliation is not triggered on every module update. Will update here when that PR is merged and merge yours as well :) |
|
@petar-cvit any updates on this? |
2 participants
📑 Description
Updated the
setStatusfunction in theModuleReconcilerto include theFinishedAttimestamp in the reconciliation status. TheFinishedAtfield now uses the current time, formatted as a string in RFC3339 format. Updated the custom JSON marshaler and unmarshaler forReconciliationStatusto handle this timestamp field correctly. Fixes #430FinishedAtfield of typestringtoReconciliationStatus.setStatusfunction to setFinishedAtto the current time in RFC3339 format.FinishedAtbetweentime.Timeandstring.✅ Checks
setStatusfunction updates theFinishedAttimestamp correctly.FinishedAtfield as expected.ℹ Additional context
ReconciliationStatusstruct to include aFinishedAtfield.setStatusfunction in theModuleReconcilerto set theFinishedAtfield to the current time.FinishedAttimestamp.