Fix get_device_alarms #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example.py fails to run with:
```
./example.py
Traceback (most recent call last):
File "/Users/parminderdhillon/projects/python-garminconnect/./example.py", line 20, in <module>
from garminconnect import (
File "/Users/parminderdhillon/projects/python-garminconnect/garminconnect/__init__.py", line 15, in <module>
class Garmin:
File "/Users/parminderdhillon/projects/python-garminconnect/garminconnect/__init__.py", line 727, in Garmin
def get_device_alarms(self) -> List[str, Any]:
~~~~^^^^^^^^^^
File "/usr/local/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/typing.py", line 358, in inner
return func(*args, **kwds)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/typing.py", line 1569, in __getitem__
_check_generic(self, params, self._nparams)
File "/usr/local/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/typing.py", line 286, in _check_generic
raise TypeError(f"Too {'many' if alen > elen else 'few'} arguments for {cls};"
TypeError: Too many arguments for typing.List; actual 2, expected 1
```
|
Thank you fixing this bug/unwanted change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
def get_device_alarms(self) -> List[str, Any]:withdef get_device_alarms(self) -> Dict[str, Any]:Closes #177