Summary

Various code cleanups

Details

• Remove :have_option_value matcher
• Remove :be_valid_option matcher
• Simplify set_environment_variable features
• Temporarily disable RSpec/PredicateMatcher cop
• Correct Gemspec/RequiredRubyVersion offenses
• Disable AmbiguousX cops
• Fix Lint/MissingSuper offenses
• Replace custom include_an_object matcher with RSpec's include matcher
• Use RSpec's all matcher the regular way
• Remove obsolete requires of 'rspec/expectations/version'
• Remove unused ObjectFormatter and BaseMatcher classes
• Move event bus specs to their logical location
• Clean up event bus specs
• Fix Lint/Void offenses
• Fix Naming/ConstantName offense
• Improve scenario identifiers when reporting scenario timing
• Regenerate RuboCop to-do file

Motivation and Context

The new RuboCop release was erroring on our spec support code loaders, and I took a look at those support files. This lead to removing some of the support logic that wasn't really earning its keep. After that, I just felt like fixing some of the items in the RuboCop to-do file.

How Has This Been Tested?

I ran the specs and cukes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.