Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop and fix new offenses #724

Merged
merged 7 commits into from
Aug 21, 2020
Merged

Update rubocop and fix new offenses #724

merged 7 commits into from
Aug 21, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Aug 6, 2020

Summary

Updates rubocop gems and their configuration and fixes some offenses

Details

This pull requests does a couple of things:

  • It tightens the rubocop dependency again, since there still are breaking changes in minor versions before 1.0, for example in changed cop names and configuration names
  • It enables new cops by default, so updating rubocop doesn't entail manually enabling new cops. The tightened dependency makes sure this doesn't cause unexpected build failures
  • It updates rubocop to the current latest version, 0.89.0
  • It fixes some of the new offenses from new cops, and adds the others to the to-do list
  • Finally, it updates rubocop-packaging

Motivation and Context

Keeps things up-to-date, and makes future updates of rubocop easier.

How Has This Been Tested?

Rubocop was run again after all changes were made.

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)

@mvz mvz merged commit cd24f90 into master Aug 21, 2020
@mvz mvz deleted the update-rubocop branch August 21, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant