Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop git ls-files in gemspec #721

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Drop git ls-files in gemspec #721

merged 3 commits into from
Jul 16, 2020

Conversation

utkarsh2102
Copy link
Member

@utkarsh2102 utkarsh2102 commented Jul 16, 2020 •
edited
Loading

Hi,

Thanks for working on this! ❤️
However, while maintaining this in Debian, we found that this library relies on git to list the files which could be done via pure Ruby alternative -- which is what this PR does.

As an addition, this PR makes sure that this gem only ships the required files to the end-users and not other things which are not needed by them! 🚀

Also, added rubocop-packaging as a development_dependency which will ensure the best practices.
Here's what it shows:

Inspecting 172 files
...C..........C.........C...........
....................................
....................................
....................................
............................

Offenses:

aruba.gemspec:48:16: C: Packaging/GemspecGit: Avoid using git to produce lists of files.
Downstreams often need to build your package in an environment that does not have git (on purpose).
Use some pure Ruby alternative, like Dir or Dir.glob.
  spec.files = `git ls-files -z`.split("\x0").reject do |f|
               ^^^^^^^^^^^^^^^^^
fixtures/cli-app/cli-app.gemspec:18:24: C: Packaging/GemspecGit: Avoid using git to produce lists of files.
Downstreams often need to build your package in an environment that does not have git (on purpose).
Use some pure Ruby alternative, like Dir or Dir.glob.
  spec.files         = `git ls-files -z`.split("\x0")
                       ^^^^^^^^^^^^^^^^^
fixtures/empty-app/cli-app.gemspec:18:24: C: Packaging/GemspecGit: Avoid using git to produce lists of files.
Downstreams often need to build your package in an environment that does not have git (on purpose).
Use some pure Ruby alternative, like Dir or Dir.glob.
  spec.files         = `git ls-files -z`.split("\x0")
                       ^^^^^^^^^^^^^^^^^

172 files inspected, 3 offenses detected

And this PR fixes the same, which helps us in shipping this in Debian! 🎉
Hope this would make sense and you'll be open to this change 💯

Signed-off-by: Utkarsh Gupta <[email protected]>

CC: @luke-hill
Closes: #720

@olleolleolle olleolleolle mentioned this pull request Jul 16, 2020
Closed
@utkarsh2102
Drop git ls-files in gemspec
e710b9e 
Signed-off-by: Utkarsh Gupta <[email protected]>
mvz
mvz reviewed Jul 16, 2020
View reviewed changes
aruba.gemspec Outdated Show resolved Hide resolved
@utkarsh2102 utkarsh2102 requested a review from mvz July 16, 2020 08:22
@utkarsh2102
Respect .gitignore
5909cc2 
Signed-off-by: Utkarsh Gupta <[email protected]>
@utkarsh2102 utkarsh2102 requested a review from olleolleolle July 16, 2020 08:24
mvz
mvz approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@utkarsh2102 utkarsh2102 merged commit 99a9197 into cucumber:master Jul 16, 2020
@utkarsh2102 utkarsh2102 deleted the drop-git branch July 16, 2020 13:26
@mvz mvz mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvz mvz mvz approved these changes

@olleolleolle olleolleolle Awaiting requested review from olleolleolle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop git from gemspec
3 participants
@utkarsh2102 @olleolleolle @mvz