Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various code cleanups #717

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Various code cleanups #717

merged 5 commits into from
Jun 5, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jun 5, 2020

Summary

Some small improvements collected over time.

Details

See commit messages.

Motivation and Context

These are improvements I happened upon while working on other stuff that didn't fit in there. Nothing major.

How Has This Been Tested?

I ran bundle exec rake

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)

olleolleolle
olleolleolle approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All improvement steps here improve readability! Super.

@mvz mvz force-pushed the code-cleanups branch from 9ee5246 to 933babe Compare June 5, 2020 10:25
@mvz mvz merged commit ee4ce52 into master Jun 5, 2020
@mvz mvz deleted the code-cleanups branch June 5, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle