Correct several Style/MethodMissingSuper offenses

cucumber · mvz · Jun 1, 2020 · May 31, 2020 · May 31, 2020 · May 31, 2020
commit fc44042c9bc59d25561309efef419feb7c1a7c6e
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -297,7 +297,4 @@ Style/IdenticalConditionalBranches:
 # Offense count: 5
 Style/MethodMissingSuper:
   Exclude:
-    - 'lib/aruba/config_wrapper.rb'
-    - 'lib/aruba/in_config_wrapper.rb'
     - 'lib/aruba/platforms/command_monitor.rb'
-    - 'lib/aruba/tasks/docker_helpers.rb'
diff --git a/lib/aruba/config_wrapper.rb b/lib/aruba/config_wrapper.rb
@@ -32,7 +32,9 @@ def initialize(config, event_bus)
     def method_missing(name, *args, &block)
       notify(name, args) if name.to_s.end_with?('=')
 
-      config.send(name, *args, &block)
+      return config.send(name, *args, &block) if config.respond_to? name
+
+      super
     end
 
     # Pass on respond_to?-calls

diff --git a/lib/aruba/in_config_wrapper.rb b/lib/aruba/in_config_wrapper.rb
@@ -15,18 +15,17 @@ def initialize(config)
     end
 
     def method_missing(name, *args)
-      raise ArgumentError, 'Options take no argument' if args.any?
+      if config.key? name
+        raise ArgumentError, 'Options take no argument' if args.any?
 
-      unless config.key? name
-        raise UnknownOptionError,
-              %(Option "#{name}" is unknown. Please use only earlier defined options)
+        config[name]
+      else
+        super
       end
-
-      config[name]
     end
 
-    def respond_to_missing?(*)
-      true
+    def respond_to_missing?(name, _include_private)
+      config.key? name
     end
   end
 end
diff --git a/lib/aruba/tasks/docker_helpers.rb b/lib/aruba/tasks/docker_helpers.rb
@@ -14,7 +14,9 @@ def initialize(file, instance)
     end
 
     def method_missing(m, *_args)
-      @file.public_send m, instance
+      return @file.public_send m, instance if @file.respond_to?(m)
+
+      super
     end
 
     def respond_to_missing?(m)

diff --git a/spec/aruba/in_config_wrapper_spec.rb b/spec/aruba/in_config_wrapper_spec.rb
@@ -24,9 +24,7 @@
 
   context 'when option is not defined' do
     it 'raises an error' do
-      expect { wrapper.opt }
-        .to raise_error ArgumentError,
-                        'Option "opt" is unknown. Please use only earlier defined options'
+      expect { wrapper.opt }.to raise_error NoMethodError
     end
   end
 end