Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simplecov #704

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Update simplecov #704

merged 3 commits into from
Jan 31, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 30, 2020

Summary

Update simplecov and its configuration

Details

Update simplecov to version 0.18, activate branch coverage, and make coverage of spec files work.

Motivation and Context

Keeps things up to date, and branch coverage is a nice new feature.

How Has This Been Tested?

I ran the specs and checked the resulting coverage file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

olleolleolle
olleolleolle approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The 2.7 CI failure seems to be about a warning output. The output mentions "calling private without arguments may..." Only occurs in a single test.)

Branch coverage! Can't wait to take a look at what it looks like in this codebase.

@mvz mvz merged commit eca540a into master Jan 31, 2020
@mvz mvz deleted the update-simplecov branch January 31, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle